Hi Jacopo, Thank you for the patch. On Wed, Aug 14, 2019 at 10:28:11PM +0200, Jacopo Mondi wrote: > Add the 'location' device property, used to specify the camera device > mounting position. The property is particularly meaningful for mobile > devices with a well defined usage orientation. > > Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/media/video-interfaces.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt > index f884ada0bffc..819077b2649c 100644 > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > @@ -89,6 +89,10 @@ Optional properties > but a number of degrees counter clockwise. Typical values are 0 and 180 > (upside down). > > +- location: The camera device mounting position, relative to the device > + usage orientation. Possible values are: I would mention "camera sensor" explicitly here, as well as clearly stating that the property applies to camera sensors only. > + 0 - Front camera. The image sensor is mounted on the front side of the device. > + 1 - Back camera. The image sensor is mounted on the back side of the device. An additional paragraph explained what "device usage orientation" means would be useful. In particular I would give examples for phones, tablets and laptops. > > Optional endpoint properties > ---------------------------- -- Regards, Laurent Pinchart
