Hi again,
On 7/15/2019 8:28 AM, Sean Young wrote:
> Hi,
>
> On Tue, Jun 25, 2019 at 05:29:02PM -0400, A Sun wrote:
>> In a quick look though other USB drivers, here are some other possibilities:
>>
>> Endpoint-in / Endpoint-out (not concise)
>> ep-in / ep-out (abbrev may be too obscure)
>> in / out ("Error: in urb status.." confusing,
>> "in" is noun, adj, or verb?)
>> read / write (confusing, "read" is noun, adj, verb?)
>> RD / WR
>> RX / TX
>>
>> I suggest RX/TX. However, I'll have to leave it up to you to make a choice.
>
> TBH I've been mulling this over. I think you're right that the terms should
> be usb centric. TX seems confusing, there are mceusb devices with no IR
> transmit ports, so it would be surprising to see errors about TX. Your
> first option is usb centric and can be wordy in errors messages and concise
> in code (option #2).
>
> However as you're writing patches I'll leave it up to you. It would be nice
> if the usage is consistent in the driver code.
>
ok, I'll leave this patch proposal as is, where RX/TX is the favored terminology.
rx/tx was already in use elsewhere outside the message text of this patch,
and is prevalent in mceusb_dev_printdata() output.
I also found that my later patch submission:
[PATCH v1] [media] mceusb: USB reset device following USB clear halt error
has an unintended dependency on this [PATCH v2 2/3].
FYI, I'm in progress on another mceusb patch to fix, and eliminate, the driver's
TX IR length limits. Limit causes -EINVAL errors for > ~300 pulse/space samples and
I've seen reports (and patches for) of appliances with IR over 400 pulse/spaces.
The future patch rewrites:
mceusb_tx_ir()
And revises "write/tx" async I/O to sync I/O to do unlimited multipart TX IR.
These functions will need rewrite and rename:
mce_async_callback() -> mce_tx_callback()
mce_request_packet() -> mce_tx()
The present mce_async_out() name will become misleading. mce_command_out()
or mce_request_out() (which calls mce_tx()), are probably better names.
I'm still mulling over whether the more generic "read/write" term
(e.g. mce_write() and mce_write_callback()) may be a better migration path,
for future work.
Thanks, ..A Sun
