Hi Sean,
On 7/21/19 8:29 PM, Sean Young wrote:
On Fri, Jul 19, 2019 at 08:35:42PM +0200, Jan Pieter van Woerkom wrote:
dvbsky: add MyGica T230.
Moved from cxusb driver as that driver can't handle FX2 FIFO issue.
Well then it should be deleted from the cxusb driver. Also how well
is this tested?
I'm watching DVB-T2 TV now with this for a couple of days
and see no problems. Will test on DVB-C coming week.
James will also test coming week.
The driver in cxusb crashes the kernel when I remove the
stick while running. That is gone with this. I needed that.
Another advantage is one can switch off the RC. I needed
that too. And almost all code was already in dvbsky.
Yep it should be deleted from cxusb. I now blacklist that
module while testing.
Thanks
Sean
Thank you,
Jan Pieter.
Signed-off-by: Jan Pieter van Woerkom <jp@xxxxxxx>
---
diff -ru a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c
--- a/drivers/media/usb/dvb-usb-v2/dvbsky.c 2019-07-08 00:41:56.000000000 +0200
+++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c 2019-07-19 17:50:54.671341146 +0200
@@ -561,11 +561,18 @@
/* attach tuner */
si2157_config.fe = adap->fe[0];
- si2157_config.if_port = 0;
-
- state->i2c_client_tuner = dvb_module_probe("si2157", "si2141",
+ if (le16_to_cpu(d->udev->descriptor.idProduct) == USB_PID_MYGICA_T230) {
+ si2157_config.if_port = 1;
+ state->i2c_client_tuner = dvb_module_probe("si2157", NULL,
+ i2c_adapter,
+ 0x60, &si2157_config);
+ }
+ else {
+ si2157_config.if_port = 0;
+ state->i2c_client_tuner = dvb_module_probe("si2157", "si2141",
i2c_adapter,
0x60, &si2157_config);
+ }
if (!state->i2c_client_tuner) {
dvb_module_release(state->i2c_client_demod);
return -ENODEV;
@@ -787,6 +794,9 @@
{ DVB_USB_DEVICE(USB_VID_TERRATEC, USB_PID_TERRATEC_CINERGY_S2_R4,
&dvbsky_s960_props, "Terratec Cinergy S2 Rev.4",
RC_MAP_DVBSKY) },
+ { DVB_USB_DEVICE(USB_VID_CONEXANT, USB_PID_MYGICA_T230,
+ &mygica_t230c_props, "MyGica Mini DVB-T2 USB Stick T230",
+ RC_MAP_TOTAL_MEDIA_IN_HAND_02) },
{ DVB_USB_DEVICE(USB_VID_CONEXANT, USB_PID_MYGICA_T230C,
&mygica_t230c_props, "MyGica Mini DVB-T2 USB Stick T230C",
RC_MAP_TOTAL_MEDIA_IN_HAND_02) },
