On Wed, Jun 19, 2019 at 03:54:21AM -0400, A Sun wrote: > > Clarify messages referencing "request urb" to mean "tx urb" > (host transmit/send (to mceusb device)). > Qualify messages referencing plain "urb" to mean "rx urb" > (host receive (from mceusb device)). > Add missing "couldn't allocate rx urb" error message. > Clean extraneous "\n" in dev_dbg messages. > > Signed-off-by: A Sun <as1033x@xxxxxxxxxxx> > --- > drivers/media/rc/mceusb.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c > index 0cd8f6f57..efffb1795 100644 > --- a/drivers/media/rc/mceusb.c > +++ b/drivers/media/rc/mceusb.c > @@ -796,13 +796,13 @@ static void mce_async_callback(struct urb *urb) > break; > > case -EPIPE: > - dev_err(ir->dev, "Error: request urb status = %d (TX HALT)", > + dev_err(ir->dev, "Error: tx urb status = %d (TX HALT)", I am not sure this makes things clearer. Some of the code still refers to request, e.g. mce_request_packet. Since this is an IR device, there is IR TX and RX; however this unrelated to that. There is one urb/endpoint on which commands are sent; on the other, we receiver responses and IR data. Calling those TX and RX is not a good idea I think. The existing code refers to request and response, and also TX and RX in places. The microsoft documentation refers to "command and response" which would be consistent with the #define's we have (MCE_CMD_* and MCE_RSP_*). Thanks Sean
