Re: [PATCH] ov534: fix end of frame handling, make the camera work again.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Antonio Ospite wrote:
> Fix a regression, probably introduced in the driver split, which made
> the ov534 driver unusable: every last packet was discarded because we
> were mis-calculating the frame size before actually adding the packet.

Hi Antonio,

> Index: gspca/linux/drivers/media/video/gspca/ov534.c
> ===================================================================
> --- gspca.orig/linux/drivers/media/video/gspca/ov534.c
> +++ gspca/linux/drivers/media/video/gspca/ov534.c
> @@ -992,9 +992,9 @@
>  			frame = gspca_get_i_frame(gspca_dev);
>  			if (frame == NULL)
>  				goto discard;
> -			if (frame->data_end - frame->data !=
> +			if (frame->data_end - frame->data + (len - 12) !=
>  			    gspca_dev->width * gspca_dev->height * 2) {
> -				PDEBUG(D_PACK, "short frame");
> +				PDEBUG(D_PACK, "wrong sized frame");
>  				goto discard;
>  			}
>  			gspca_frame_add(gspca_dev, LAST_PACKET,

This change looks correct to me.  Thanks.

Acked-by: Jim Paris <jim@xxxxxxxx>

-jim
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux