Guennadi Liakhovetski wrote: > Hi Mauro > > On Mon, 14 Dec 2009, Mauro Carvalho Chehab wrote: > >> Guennadi Liakhovetski wrote: >>> So, is the doc patch, that I've sent to the list ok? Ok, the hunk for the >>> automatically (in hg) generated file will get dropped, and otherwise does >>> it look correct? >> It looks correctly on my eyes. The only thing I noticed is that you've added >> emacs headers at the end of the new patches: >> >> + >> + <!-- >> +Local Variables: >> +mode: sgml >> +sgml-parent-document: "pixfmt.sgml" >> +indent-tabs-mode: nil >> +End: >> + --> >> >> Please remove those tags when submitting the final version. > > I tried to just through away the media-specs/media-entities.tmpl hunk, as > that file should be auto-generated, but the new version doesn't include > the new formats either. What am I doing wrong? The patch attached below. As you're adding new files, you need to tell Makefile to take a look on them also. So, just add the new files to V4L_SGMLS list at Makefile should do the job. Cheers, Mauro. > > Thanks > Guennadi > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ > > # HG changeset patch > # User Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > # Date 1261648434 -3600 > # Node ID 52e14d4799279a860fe158e77778bf4f1993d6c6 > # Parent 4506e2d541265bfa0c0fd5187c6a39d39a456559 > document new pixel formats > > Document all four 10-bit Bayer formats, 10-bit monochrome and a missing > 8-bit Bayer formats. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > diff -r 4506e2d54126 -r 52e14d479927 linux/Documentation/DocBook/v4l/pixfmt-srggb10.xml > --- /dev/null Thu Jan 01 00:00:00 1970 +0000 > +++ b/linux/Documentation/DocBook/v4l/pixfmt-srggb10.xml Thu Dec 24 10:53:54 2009 +0100 > @@ -0,0 +1,90 @@ > + <refentry> > + <refmeta> > + <refentrytitle>V4L2_PIX_FMT_SRGGB10 ('RG10'), > + V4L2_PIX_FMT_SGRBG10 ('BA10'), > + V4L2_PIX_FMT_SGBRG10 ('GB10'), > + V4L2_PIX_FMT_SBGGR10 ('BG10'), > + </refentrytitle> > + &manvol; > + </refmeta> > + <refnamediv> > + <refname id="V4L2-PIX-FMT-SRGGB10"><constant>V4L2_PIX_FMT_SRGGB10</constant></refname> > + <refname id="V4L2-PIX-FMT-SGRBG10"><constant>V4L2_PIX_FMT_SGRBG10</constant></refname> > + <refname id="V4L2-PIX-FMT-SGBRG10"><constant>V4L2_PIX_FMT_SGBRG10</constant></refname> > + <refname id="V4L2-PIX-FMT-SBGGR10"><constant>V4L2_PIX_FMT_SBGGR10</constant></refname> > + <refpurpose>10-bit Bayer formats expanded to 16 bits</refpurpose> > + </refnamediv> > + <refsect1> > + <title>Description</title> > + > + <para>The following four pixel formats are raw sRGB / Bayer formats with > +10 bits per colour. Each colour component is stored in a 16-bit word, with 6 > +unused high bits filled with zeros. Each n-pixel row contains n/2 green samples > +and n/2 blue or red samples, with alternating red and blue rows. Bytes are > +stored in memory in little endian order. They are conventionally described > +as GRGR... BGBG..., RGRG... GBGB..., etc. Below is an example of one of these > +formats</para> > + > + <example> > + <title><constant>V4L2_PIX_FMT_SBGGR10</constant> 4 × 4 > +pixel image</title> > + > + <formalpara> > + <title>Byte Order.</title> > + <para>Each cell is one byte, high 6 bits in high bytes are 0. > + <informaltable frame="none"> > + <tgroup cols="5" align="center"> > + <colspec align="left" colwidth="2*" /> > + <tbody valign="top"> > + <row> > + <entry>start + 0:</entry> > + <entry>B<subscript>00low</subscript></entry> > + <entry>B<subscript>00high</subscript></entry> > + <entry>G<subscript>01low</subscript></entry> > + <entry>G<subscript>01high</subscript></entry> > + <entry>B<subscript>02low</subscript></entry> > + <entry>B<subscript>02high</subscript></entry> > + <entry>G<subscript>03low</subscript></entry> > + <entry>G<subscript>03high</subscript></entry> > + </row> > + <row> > + <entry>start + 8:</entry> > + <entry>G<subscript>10low</subscript></entry> > + <entry>G<subscript>10high</subscript></entry> > + <entry>R<subscript>11low</subscript></entry> > + <entry>R<subscript>11high</subscript></entry> > + <entry>G<subscript>12low</subscript></entry> > + <entry>G<subscript>12high</subscript></entry> > + <entry>R<subscript>13low</subscript></entry> > + <entry>R<subscript>13high</subscript></entry> > + </row> > + <row> > + <entry>start + 16:</entry> > + <entry>B<subscript>20low</subscript></entry> > + <entry>B<subscript>20high</subscript></entry> > + <entry>G<subscript>21low</subscript></entry> > + <entry>G<subscript>21high</subscript></entry> > + <entry>B<subscript>22low</subscript></entry> > + <entry>B<subscript>22high</subscript></entry> > + <entry>G<subscript>23low</subscript></entry> > + <entry>G<subscript>23high</subscript></entry> > + </row> > + <row> > + <entry>start + 24:</entry> > + <entry>G<subscript>30low</subscript></entry> > + <entry>G<subscript>30high</subscript></entry> > + <entry>R<subscript>31low</subscript></entry> > + <entry>R<subscript>31high</subscript></entry> > + <entry>G<subscript>32low</subscript></entry> > + <entry>G<subscript>32high</subscript></entry> > + <entry>R<subscript>33low</subscript></entry> > + <entry>R<subscript>33high</subscript></entry> > + </row> > + </tbody> > + </tgroup> > + </informaltable> > + </para> > + </formalpara> > + </example> > + </refsect1> > +</refentry> > diff -r 4506e2d54126 -r 52e14d479927 linux/Documentation/DocBook/v4l/pixfmt-srggb8.xml > --- /dev/null Thu Jan 01 00:00:00 1970 +0000 > +++ b/linux/Documentation/DocBook/v4l/pixfmt-srggb8.xml Thu Dec 24 10:53:54 2009 +0100 > @@ -0,0 +1,67 @@ > + <refentry id="V4L2-PIX-FMT-SRGGB8"> > + <refmeta> > + <refentrytitle>V4L2_PIX_FMT_SRGGB8 ('RGGB')</refentrytitle> > + &manvol; > + </refmeta> > + <refnamediv> > + <refname><constant>V4L2_PIX_FMT_SRGGB8</constant></refname> > + <refpurpose>Bayer RGB format</refpurpose> > + </refnamediv> > + <refsect1> > + <title>Description</title> > + > + <para>This is commonly the native format of digital cameras, > +reflecting the arrangement of sensors on the CCD device. Only one red, > +green or blue value is given for each pixel. Missing components must > +be interpolated from neighbouring pixels. From left to right the first > +row consists of a red and green value, the second row of a green and > +blue value. This scheme repeats to the right and down for every two > +columns and rows.</para> > + > + <example> > + <title><constant>V4L2_PIX_FMT_SRGGB8</constant> 4 × 4 > +pixel image</title> > + > + <formalpara> > + <title>Byte Order.</title> > + <para>Each cell is one byte. > + <informaltable frame="none"> > + <tgroup cols="5" align="center"> > + <colspec align="left" colwidth="2*" /> > + <tbody valign="top"> > + <row> > + <entry>start + 0:</entry> > + <entry>R<subscript>00</subscript></entry> > + <entry>G<subscript>01</subscript></entry> > + <entry>R<subscript>02</subscript></entry> > + <entry>G<subscript>03</subscript></entry> > + </row> > + <row> > + <entry>start + 4:</entry> > + <entry>G<subscript>10</subscript></entry> > + <entry>B<subscript>11</subscript></entry> > + <entry>G<subscript>12</subscript></entry> > + <entry>B<subscript>13</subscript></entry> > + </row> > + <row> > + <entry>start + 8:</entry> > + <entry>R<subscript>20</subscript></entry> > + <entry>G<subscript>21</subscript></entry> > + <entry>R<subscript>22</subscript></entry> > + <entry>G<subscript>23</subscript></entry> > + </row> > + <row> > + <entry>start + 12:</entry> > + <entry>G<subscript>30</subscript></entry> > + <entry>B<subscript>31</subscript></entry> > + <entry>G<subscript>32</subscript></entry> > + <entry>B<subscript>33</subscript></entry> > + </row> > + </tbody> > + </tgroup> > + </informaltable> > + </para> > + </formalpara> > + </example> > + </refsect1> > + </refentry> > diff -r 4506e2d54126 -r 52e14d479927 linux/Documentation/DocBook/v4l/pixfmt-y10.xml > --- /dev/null Thu Jan 01 00:00:00 1970 +0000 > +++ b/linux/Documentation/DocBook/v4l/pixfmt-y10.xml Thu Dec 24 10:53:54 2009 +0100 > @@ -0,0 +1,79 @@ > +<refentry id="V4L2-PIX-FMT-Y10"> > + <refmeta> > + <refentrytitle>V4L2_PIX_FMT_Y10 ('Y10 ')</refentrytitle> > + &manvol; > + </refmeta> > + <refnamediv> > + <refname><constant>V4L2_PIX_FMT_Y10</constant></refname> > + <refpurpose>Grey-scale image</refpurpose> > + </refnamediv> > + <refsect1> > + <title>Description</title> > + > + <para>This is a grey-scale image with a depth of 10 bits per pixel. Pixels > +are stored in 16-bit words with unused high bits padded with 0. The least > +significant byte is stored at lower memory addresses (little-endian).</para> > + > + <example> > + <title><constant>V4L2_PIX_FMT_Y10</constant> 4 × 4 > +pixel image</title> > + > + <formalpara> > + <title>Byte Order.</title> > + <para>Each cell is one byte. > + <informaltable frame="none"> > + <tgroup cols="9" align="center"> > + <colspec align="left" colwidth="2*" /> > + <tbody valign="top"> > + <row> > + <entry>start + 0:</entry> > + <entry>Y'<subscript>00low</subscript></entry> > + <entry>Y'<subscript>00high</subscript></entry> > + <entry>Y'<subscript>01low</subscript></entry> > + <entry>Y'<subscript>01high</subscript></entry> > + <entry>Y'<subscript>02low</subscript></entry> > + <entry>Y'<subscript>02high</subscript></entry> > + <entry>Y'<subscript>03low</subscript></entry> > + <entry>Y'<subscript>03high</subscript></entry> > + </row> > + <row> > + <entry>start + 8:</entry> > + <entry>Y'<subscript>10low</subscript></entry> > + <entry>Y'<subscript>10high</subscript></entry> > + <entry>Y'<subscript>11low</subscript></entry> > + <entry>Y'<subscript>11high</subscript></entry> > + <entry>Y'<subscript>12low</subscript></entry> > + <entry>Y'<subscript>12high</subscript></entry> > + <entry>Y'<subscript>13low</subscript></entry> > + <entry>Y'<subscript>13high</subscript></entry> > + </row> > + <row> > + <entry>start + 16:</entry> > + <entry>Y'<subscript>20low</subscript></entry> > + <entry>Y'<subscript>20high</subscript></entry> > + <entry>Y'<subscript>21low</subscript></entry> > + <entry>Y'<subscript>21high</subscript></entry> > + <entry>Y'<subscript>22low</subscript></entry> > + <entry>Y'<subscript>22high</subscript></entry> > + <entry>Y'<subscript>23low</subscript></entry> > + <entry>Y'<subscript>23high</subscript></entry> > + </row> > + <row> > + <entry>start + 24:</entry> > + <entry>Y'<subscript>30low</subscript></entry> > + <entry>Y'<subscript>30high</subscript></entry> > + <entry>Y'<subscript>31low</subscript></entry> > + <entry>Y'<subscript>31high</subscript></entry> > + <entry>Y'<subscript>32low</subscript></entry> > + <entry>Y'<subscript>32high</subscript></entry> > + <entry>Y'<subscript>33low</subscript></entry> > + <entry>Y'<subscript>33high</subscript></entry> > + </row> > + </tbody> > + </tgroup> > + </informaltable> > + </para> > + </formalpara> > + </example> > + </refsect1> > +</refentry> > diff -r 4506e2d54126 -r 52e14d479927 linux/Documentation/DocBook/v4l/pixfmt.xml > --- a/linux/Documentation/DocBook/v4l/pixfmt.xml Wed Dec 23 12:28:46 2009 -0200 > +++ b/linux/Documentation/DocBook/v4l/pixfmt.xml Thu Dec 24 10:53:54 2009 +0100 > @@ -566,7 +566,9 @@ access the palette, this must be done wi > &sub-sbggr8; > &sub-sgbrg8; > &sub-sgrbg8; > + &sub-srggb8; > &sub-sbggr16; > + &sub-srggb10; > </section> > > <section id="yuv-formats"> > @@ -589,6 +591,7 @@ information.</para> > > &sub-packed-yuv; > &sub-grey; > + &sub-y10; > &sub-y16; > &sub-yuyv; > &sub-uyvy; > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
