Andy Walls wrote: > Mauro, > > If no one has any objections, please pull from > > http://linuxtv.org/hg/~awalls/v4l-dvb-misc > > for the following 12 changesets. > > Of note: > 02-04 are from Jean Delvare and fix up the cx23885 i2c routines > 05-17 and 12 add and use a new v4l2_subdev core op for configuring I/O pin muxes > 08-10 are some minor cx23885 ir fixes noted when trying to get the TeVii S470 working > > 10/12: cx23885: Convert from struct card_ir to struct cx23885_ir_input for IR Rx > http://linuxtv.org/hg/~awalls/v4l-dvb-misc?cmd=changeset;node=aa62944baa92 Hmm... This doesn't sound right: +struct cx23885_ir_input { + struct input_dev *dev; + struct ir_input_state ir; + char name[48]; + char phys[48]; + + /* Cooked code processing */ + int start; /* Allowed start symbols */ + u32 addr; /* Expected remote address */ + u32 last_code; /* last good cooked code seen */ + int key_timeout; /* ms until we force a key up */ + struct timer_list timer_keyup; /* timer for key release */ + + /* Raw code collection and construction */ + int active; /* building code */ + int last_bit; /* last bit seen */ + u32 code; /* code under construction */ +}; Why are you creating a name[] and phys[] chars here? It should be using the names already defined at struct input_dev. Cheers, Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
