On Tue, Oct 30, 2018 at 01:03:18PM +0100, Hans Verkuil wrote: > On 10/30/2018 12:00 AM, Sakari Ailus wrote: > > The tw9910 driver does not depend on SoC camera framework. Don't include > > the header, but instead include media/v4l2-async.h which the driver really > > needs. > > You might want to make a note of the fact that soc_camera.h includes > v4l2-async.h, so removing soc_camera.h requires adding v4l2-async.h. > > I couldn't understand how it compiled before without the v4l2-async.h > header until I saw that soc_camera.h includes it. Yes. How about this: Also include i2c/v4l2-async.h in drivers/media/i2c/tw9910.c as it depends on the header which used to be included through media/soc_camera.h. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
