On 10/30/2018 12:00 AM, Sakari Ailus wrote: > The tw9910 driver does not depend on SoC camera framework. Don't include > the header, but instead include media/v4l2-async.h which the driver really > needs. You might want to make a note of the fact that soc_camera.h includes v4l2-async.h, so removing soc_camera.h requires adding v4l2-async.h. I couldn't understand how it compiled before without the v4l2-async.h header until I saw that soc_camera.h includes it. Regards, Hans > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > --- > drivers/media/i2c/tw9910.c | 1 + > include/media/i2c/tw9910.h | 2 -- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c > index 7087ce946af1..6478bd41afb8 100644 > --- a/drivers/media/i2c/tw9910.c > +++ b/drivers/media/i2c/tw9910.c > @@ -27,6 +27,7 @@ > #include <linux/videodev2.h> > > #include <media/i2c/tw9910.h> > +#include <media/v4l2-async.h> > #include <media/v4l2-subdev.h> > > #define GET_ID(val) ((val & 0xF8) >> 3) > diff --git a/include/media/i2c/tw9910.h b/include/media/i2c/tw9910.h > index bec8f7bce745..2f93799d5a21 100644 > --- a/include/media/i2c/tw9910.h > +++ b/include/media/i2c/tw9910.h > @@ -16,8 +16,6 @@ > #ifndef __TW9910_H__ > #define __TW9910_H__ > > -#include <media/soc_camera.h> > - > /** > * tw9910_mpout_pin - MPOUT (multi-purpose output) pin functions > */ >
