Re: [PATCH 3/4] SoC camera: Remove the framework and the drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Tue, 30 Oct 2018 01:21:34 +0200
Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu:

> The SoC camera framework has been obsolete for some time and it is no
> longer functional. A few drivers have been converted to the V4L2
> sub-device API but for the rest the conversion has not taken place yet.
> 
> In order to keep the tree clean and to avoid keep maintaining
> non-functional and obsolete code, remove the SoC camera framework as well
> as the drivers that depend on it.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> ---
> Resending, this time with git format-patch -D .
> 
>  MAINTAINERS                                        |    8 -
>  drivers/media/i2c/Kconfig                          |    8 -
>  drivers/media/i2c/Makefile                         |    1 -
>  drivers/media/i2c/soc_camera/Kconfig               |   66 -
>  drivers/media/i2c/soc_camera/Makefile              |   10 -
>  drivers/media/i2c/soc_camera/ov9640.h              |  208 --
>  drivers/media/i2c/soc_camera/soc_mt9m001.c         |  757 -------
>  drivers/media/i2c/soc_camera/soc_mt9t112.c         | 1157 -----------
>  drivers/media/i2c/soc_camera/soc_mt9v022.c         | 1012 ---------
>  drivers/media/i2c/soc_camera/soc_ov5642.c          | 1087 ----------
>  drivers/media/i2c/soc_camera/soc_ov772x.c          | 1123 ----------
>  drivers/media/i2c/soc_camera/soc_ov9640.c          |  738 -------
>  drivers/media/i2c/soc_camera/soc_ov9740.c          |  996 ---------
>  drivers/media/i2c/soc_camera/soc_rj54n1cb0c.c      | 1415 -------------
>  drivers/media/i2c/soc_camera/soc_tw9910.c          |  999 ---------  

I don't see why we should remove those. I mean, Jacopo is
actually converting those drivers to not depend on soc_camera,
and it is a way better to review those patches with the old
code in place.

So, at least while Jacopo is keep doing this work, I would keep
at Kernel tree, as it helps to see a diff when the driver changes
when getting rid of soc_camera dependencies.

So, IMO, the best would be to move those to /staging, eventually
depending on BROKEN.

Thanks,
Mauro



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux