On 08/14/2018 10:38 AM, jacopo mondi wrote:
Hi Steve,
On Tue, Aug 14, 2018 at 09:51:04AM -0700, Steve Longerbeam wrote:
Hi Jacopo,
On 08/14/2018 08:35 AM, jacopo mondi wrote:
Hi Steve,
sorry for resurecting this.
<snip>
I'm sorry I'm not sur I'm following. Does this mean that with that bug
you are referring to up here fixed by my last patch you have capture
working?
No, capture still not working for me on SabreSD, even after fixing
the bug in 476dec0 "media: ov5640: Add horizontal and vertical totals",
by either using your patchset, or by running version 476dec0 of ov5640.c
with the call to ov5640_set_timings() moved to the correct places as
described below.
I've been reported a bug on exposure handling that makes the first
captured frames all black. Both me and Hugues have tried to fix the
issue (him with a more complete series, but that's another topic).
See [1] and [2]
It might be possible that you're getting blank frames with this series
applied? I never seen them as I'm skipping the first frames when
capturing, but I've now tested and without the exposure fixes (either
[1] or [2]) I actually have blank frames.
If that's the case for you too (which I hope so much) would you be
available to test again this series with exposure fixes on top?
On my platform that actually makes all frames correct.
Thanks
j
[1] [PATCH 0/2] media: ov5640: Fix set_timings and auto-exposure
[2] [PATCH v2 0/5] Fix OV5640 exposure & gain
It's not clear to me which patch sets you would like me to test.
Just [1] and [2], or [1], [2], and "media: i2c: ov5640: Re-work MIPI startup
sequence"?
I have tested on my board the following:
v4.18-rc2 + MIPI Fix + Timings + Hugues' exposure fix
Without Hugues' patches I get blank frames (the first ones at least)
Without MIPI startup reowkr and timings I get the LP-11 error on the
CSI-2 bus.
As Hugues' series has to be rebased on mine, I have prepared a branch
here for you if you feel like testing it:
git://jmondi.org/linux ov5640/timings_exposure
Hi Jacopo, that branch works on SabreSD!
Feel free to add
Tested-by: Steve Longerbeam <slongerbeam@xxxxxxxxx>
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
to whichever ov5640 patches are appropriate.
Steve
