Em Mon, 14 Dec 2009 11:10:50 -0500 Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> escreveu: > On Mon, Dec 14, 2009 at 11:09 AM, Mauro Carvalho Chehab > <mchehab@xxxxxxxxxxxxx> wrote: > >> I can't pull. Your site is not responding. > > > > Hmm... it seems a temporary failure. It is working now. > > That is strange (works fine from here). You reported a similar issue > trying to pull one of Michael Krufky's trees last week. I will have > to keep an eye on it. Yep. Btw, there are a few CodingStyle issues. Please send later a patch fixing it. I'll be reviewing the patch series. Cheers, Mauro Pushing from remote site http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2, tree: hvr-1600-alsa-2 Number of patches: 14 /tmp/newpatches/hg_hvr-1600-alsa-2_01.patch with cs=878a34e7beac First patch. Patch against an older patch: changeset: 13370:7477df192a59 user: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> date: Wed Nov 18 05:12:04 2009 -0200 summary: Add a list of known issues to v4l2-apps /tmp/newpatches/hg_hvr-1600-alsa-2_02.patch with cs=a631e089c9d6 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_03.patch with cs=a20a6f8ebf42 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_04.patch with cs=f576485071d3 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_05.patch with cs=605c1f7fed3c Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_06.patch with cs=cb267593943f Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_07.patch with cs=749aa3ccbb84 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_08.patch with cs=4ea6a2a3b501 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_09.patch with cs=58c37088f6a6 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_10.patch with cs=7b6e737ddb79 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_11.patch with cs=6bc4dc4993f7 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_12.patch with cs=e47b8ea0c818 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_13.patch with cs=95df6a4cce66 Ok. /tmp/newpatches/hg_hvr-1600-alsa-2_14.patch with cs=355c08546c21 Ok. Diffstat of the imported series: linux/drivers/media/video/cx18/Kconfig | 11 linux/drivers/media/video/cx18/Makefile | 2 linux/drivers/media/video/cx18/cx18-alsa-main.c | 370 ++++++++- linux/drivers/media/video/cx18/cx18-alsa-mixer.c | 191 ++++ linux/drivers/media/video/cx18/cx18-alsa-mixer.h | 23 linux/drivers/media/video/cx18/cx18-alsa-pcm.c | 407 +++++++++- linux/drivers/media/video/cx18/cx18-alsa-pcm.h | 27 linux/drivers/media/video/cx18/cx18-alsa.c | 606 +++++++-------- linux/drivers/media/video/cx18/cx18-alsa.h | 59 + linux/drivers/media/video/cx18/cx18-driver.c | 44 + linux/drivers/media/video/cx18/cx18-driver.h | 10 linux/drivers/media/video/cx18/cx18-fileops.c | 6 linux/drivers/media/video/cx18/cx18-fileops.h | 3 linux/drivers/media/video/cx18/cx18-mailbox.c | 16 linux/drivers/media/video/cx18/cx18-streams.c | 2 15 files changed, 1429 insertions(+), 348 deletions(-) /tmp/newpatches/hg_hvr-1600-alsa-2_01.patch: cx18-alsa: Initial non-working cx18-alsa files ERROR: need consistent spacing around '+' (ctx:WxV) #124: FILE: linux/drivers/media/video/cx18/cx18-alsa-mixer.c:95: + uinfo->value.integer.max = +8; ^ total: 1 errors, 0 warnings, 579 lines checked /tmp/newpatches/hg_hvr-1600-alsa-2_02.patch: cx18-alsa: Add non-working cx18-alsa-pcm.[ch] files to avoid data loss /tmp/newpatches/hg_hvr-1600-alsa-2_04.patch: cx18: make it so cx18-alsa-main.c compiles WARNING: line over 80 characters #44: FILE: linux/drivers/media/video/cx18/cx18-alsa-main.c:44: +#define CX18_DEBUG_ALSA_INFO(fmt, arg...) printk(KERN_INFO "%s: " fmt, "cx18-alsa", ## arg) WARNING: printk() should include KERN_ facility level #89: FILE: linux/drivers/media/video/cx18/cx18-alsa-main.c:254: + printk("cx18-alsa: drv was null\n"); total: 0 errors, 2 warnings, 74 lines checked /tmp/newpatches/hg_hvr-1600-alsa-2_06.patch: cx18: overhaul ALSA PCM device handling so it works WARNING: externs should be avoided in .c files #41: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:40: +extern int cx18_alsa_debug; WARNING: externs should be avoided in .c files #50: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:49: +void cx18_alsa_announce_pcm_data(struct snd_cx18_card *cxsc, u8 *pcm_data, WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged #53: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:52: +#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16) WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged #162: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:164: +#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16) WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged #169: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:171: +#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16) WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged #232: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:240: +#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16) WARNING: line over 80 characters #361: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:389: + snd_pcm_set_ops(sp, SNDRV_PCM_STREAM_CAPTURE, &snd_cx18_pcm_capture_ops); total: 0 errors, 7 warnings, 396 lines checked /tmp/newpatches/hg_hvr-1600-alsa-2_10.patch: cx18: rework cx18-alsa module loading to support automatic loading WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #100: FILE: linux/drivers/media/video/cx18/cx18-driver.c:52: +EXPORT_SYMBOL(cx18_ext_init); WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged #131: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1220: +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20) ERROR: space required after that ',' (ctx:VxV) #131: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1220: +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20) ^ ERROR: space required after that ',' (ctx:VxV) #131: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1220: +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20) ^ ERROR: spaces required around that '=' (ctx:VxV) #138: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1227: + struct cx18 *dev=container_of(work, struct cx18, request_module_wk); ^ WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged #151: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1240: +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20) ERROR: space required after that ',' (ctx:VxV) #151: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1240: +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20) ^ ERROR: space required after that ',' (ctx:VxV) #151: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1240: +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20) ^ ERROR: "(foo*)" should be "(foo *)" #152: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1241: + INIT_WORK(&dev->request_module_wk, request_module_async, (void*)dev); total: 6 errors, 3 warnings, 150 lines checked To cherry pick all files, you can do something like: for i in /tmp/newpatches/*.patch; do ./mailimport $i; done To merge it, the better is to run the merge script: ./v4l/scripts/do_merge.pl http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
