On Wed, Mar 14, 2018 at 03:32:02PM -0400, A Sun wrote:
> patch v2 revisions:
> . Carrier frequency measurement results were consistently low in patch v1.
> Improve measurement accuracy by adjusting IR carrier cycle count
> assuming 1 missed count per IR "on" pulse.
> Adjustments may need to be hardware specific, so future refinements
> may be necessary.
I've retested my four mceusb devices. Three of them, including the original
microsoft mce ir receiver, need this fix. However, one with pid 0471 and
vid 2093 produces correct results before this change, and starts giving
carrier with numbers which are too high after this.
> . Remove unneeded argument "enable" validation in
> mceusb_set_rx_wideband() and mceusb_set_rx_carrier_report().
> . In mceusb_set_rx_carrier_report(), when enabling RX carrier report feature,
> also implicitly enable RX wide-band (short-range) receiver.
> Maintains consistency with winbond-cir, redrat3, ene-cir, IR receivers.
So if carrier reports are enabled, and then disabled again, in your code
the wideband receiver remains enabled. Please can it be disabled again
when carrier reports are turned off again (while learning mode is off).
> . Comment revisions and style corrections.
> ---
>
> Windows Media Center IR transceivers include two IR receivers;
> wide-band/short-range and narrow-band/long-range. The short-range
> (5cm distance) receiver is for IR learning and has IR carrier
> frequency measuring ability.
>
> Add mceusb driver support to select the short range IR receiver
> and enable pass through of its IR carrier frequency measurements.
>
> RC and LIRC already support these mceusb driver additions.
>
> Test platform:
>
> Linux raspberrypi 4.9.59-v7+ #1047 SMP Sun Oct 29 12:19:23 GMT 2017 armv7l GNU/Linux
> mceusb 1-1.2:1.0: Registered Pinnacle Systems PCTV Remote USB with mce emulator interface version 1
> mceusb 1-1.2:1.0: 2 tx ports (0x0 cabled) and 2 rx sensors (0x1 active)
>
> Sony TV remote control
>
> ir-ctl from v4l-utils
>
> pi@raspberrypi:~ $ ir-ctl -V
> IR raw version 1.12.3
> pi@raspberrypi:~ $ ir-ctl -m -r
> ...
> pulse 650
> space 550
> pulse 650
> space 600
> pulse 600
> space 600
> pulse 1200
> space 600
> pulse 650
> space 550
> pulse 650
> space 600
> pulse 600
> space 600
> pulse 550
> carrier 40004
> space 16777215
> ^C
> pi@raspberrypi:~ $ exit
>
> Signed-off-by: A Sun <as1033x@xxxxxxxxxxx>
> ---
> drivers/media/rc/mceusb.c | 109 ++++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 101 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
> index a9187b0b4..392d26226 100644
> --- a/drivers/media/rc/mceusb.c
> +++ b/drivers/media/rc/mceusb.c
> @@ -42,7 +42,7 @@
> #include <linux/pm_wakeup.h>
> #include <media/rc-core.h>
>
> -#define DRIVER_VERSION "1.93"
> +#define DRIVER_VERSION "1.94"
> #define DRIVER_AUTHOR "Jarod Wilson <jarod@xxxxxxxxxx>"
> #define DRIVER_DESC "Windows Media Center Ed. eHome Infrared Transceiver " \
> "device driver"
> @@ -427,6 +427,7 @@ struct mceusb_dev {
> struct rc_dev *rc;
>
> /* optional features we can enable */
> + bool carrier_report_enabled;
> bool learning_enabled;
>
> /* core device bits */
> @@ -475,6 +476,10 @@ struct mceusb_dev {
> u8 txports_cabled; /* bitmask of transmitters with cable */
> u8 rxports_active; /* bitmask of active receive sensors */
>
> + /* receiver carrier frequency detection support */
> + u32 pulse_tunit; /* IR pulse "on" cumulative time units */
> + u32 pulse_count; /* pulse "on" count in measurement interval */
> +
> /*
> * support for async error handler mceusb_deferred_kevent()
> * where usb_clear_halt(), usb_reset_configuration(),
> @@ -956,14 +961,62 @@ static int mceusb_set_tx_carrier(struct rc_dev *dev, u32 carrier)
> }
>
> /*
> + * Select or deselect the 2nd receiver port.
> + * Second receiver is learning mode, wide-band, short-range receiver.
> + * Only one receiver (long or short range) may be active at a time.
> + */
> +static int mceusb_set_rx_wideband(struct rc_dev *dev, int enable)
> +{
> + struct mceusb_dev *ir = dev->priv;
> + unsigned char cmdbuf[3] = { MCE_CMD_PORT_IR,
> + MCE_CMD_SETIRRXPORTEN, 0x00 };
> +
> + dev_dbg(ir->dev, "select %s-range receive sensor",
> + enable ? "short" : "long");
> + /*
> + * cmdbuf[2] is receiver port number
> + * port 1 is long range receiver
> + * port 2 is short range receiver
> + */
> + cmdbuf[2] = enable ? 2 : 1;
If carrier reports or learning mode is enabled, set the wideband receiver,
else the narrowband.
> + mce_async_out(ir, cmdbuf, sizeof(cmdbuf));
> +
> + return 0;
> +}
> +
> +/*
> + * Enable/disable receiver carrier frequency pass through reporting.
> + * Only the short-range receiver has carrier frequency measuring capability.
> + * Implicitly select this receiver when enabling carrier frequency reporting.
> + */
> +static int mceusb_set_rx_carrier_report(struct rc_dev *dev, int enable)
> +{
> + struct mceusb_dev *ir = dev->priv;
> +
> + dev_dbg(ir->dev, "%s short-range receiver carrier reporting",
> + enable ? "enable" : "disable");
> + if (enable) {
> + if (!ir->learning_enabled)
> + mceusb_set_rx_wideband(dev, 1);
> + ir->carrier_report_enabled = true;
> + } else {
> + ir->carrier_report_enabled = false;
Disable wideband again if learning mode is not enabled.
> + }
> +
> + return 0;
> +}
> +
> +/*
> * We don't do anything but print debug spew for many of the command bits
> * we receive from the hardware, but some of them are useful information
> * we want to store so that we can use them.
> */
> static void mceusb_handle_command(struct mceusb_dev *ir, int index)
> {
> + DEFINE_IR_RAW_EVENT(rawir);
> u8 hi = ir->buf_in[index + 1] & 0xff;
> u8 lo = ir->buf_in[index + 2] & 0xff;
> + u32 carrier_cycles;
>
> switch (ir->buf_in[index]) {
> /* the one and only 5-byte return value command */
> @@ -980,6 +1033,33 @@ static void mceusb_handle_command(struct mceusb_dev *ir, int index)
> ir->num_txports = hi;
> ir->num_rxports = lo;
> break;
> + case MCE_RSP_EQIRRXCFCNT:
> + /*
> + * The carrier cycle counter can overflow and wrap around
> + * without notice from the device. So frequency measurement
> + * will be inaccurate with long duration IR.
> + *
> + * The long-range (non learning) receiver always reports
> + * zero count so we always ignore its report.
> + */
> + if (ir->carrier_report_enabled && ir->learning_enabled &&
> + ir->pulse_tunit > 0) {
> + init_ir_raw_event(&rawir);
DEFINE_IR_RAW_EVENT() already clears rawir, no need to call init_ir_raw_event().
> + carrier_cycles = (hi << 8 | lo);
> + rawir.carrier_report = 1;
> + /*
> + * Adjust carrier cycle count by adding
> + * 1 missed count per pulse "on"
> + */
> + rawir.carrier = (1000000u / MCE_TIME_UNIT) *
> + (carrier_cycles + ir->pulse_count) /
> + ir->pulse_tunit;
> + dev_dbg(ir->dev, "RX carrier frequency %u Hz (pulse count = %u, cycles = %u, duration = %u)",
> + rawir.carrier, ir->pulse_count, carrier_cycles,
> + ir->pulse_tunit);
> + ir_raw_event_store(ir->rc, &rawir);
> + }
> + break;
>
> /* 1-byte return value commands */
> case MCE_RSP_EQEMVER:
> @@ -990,7 +1070,11 @@ static void mceusb_handle_command(struct mceusb_dev *ir, int index)
> break;
> case MCE_RSP_EQIRRXPORTEN:
> ir->learning_enabled = ((hi & 0x02) == 0x02);
> - ir->rxports_active = hi;
> + if (ir->rxports_active != hi) {
> + dev_info(ir->dev, "%s-range (0x%x) receiver active",
> + ir->learning_enabled ? "short" : "long", hi);
> + ir->rxports_active = hi;
> + }
> break;
> case MCE_RSP_CMD_ILLEGAL:
> ir->need_reset = true;
> @@ -1027,12 +1111,16 @@ static void mceusb_process_ir_data(struct mceusb_dev *ir, int buf_len)
> ir->rem--;
> init_ir_raw_event(&rawir);
> rawir.pulse = ((ir->buf_in[i] & MCE_PULSE_BIT) != 0);
> - rawir.duration = (ir->buf_in[i] & MCE_PULSE_MASK)
> - * US_TO_NS(MCE_TIME_UNIT);
> + rawir.duration = (ir->buf_in[i] & MCE_PULSE_MASK);
> + if (rawir.pulse) {
> + ir->pulse_tunit += rawir.duration;
> + ir->pulse_count++;
> + }
> + rawir.duration *= US_TO_NS(MCE_TIME_UNIT);
>
> - dev_dbg(ir->dev, "Storing %s with duration %u",
> + dev_dbg(ir->dev, "Storing %s %u ns (%02x)",
> rawir.pulse ? "pulse" : "space",
> - rawir.duration);
> + rawir.duration, ir->buf_in[i]);
>
> if (ir_raw_event_store_with_filter(ir->rc, &rawir))
> event = true;
> @@ -1053,10 +1141,13 @@ static void mceusb_process_ir_data(struct mceusb_dev *ir, int buf_len)
> ir->rem = (ir->cmd & MCE_PACKET_LENGTH_MASK);
> mceusb_dev_printdata(ir, ir->buf_in, buf_len,
> i, ir->rem + 1, false);
> - if (ir->rem)
> + if (ir->rem) {
> ir->parser_state = PARSE_IRDATA;
> - else
> + } else {
> ir_raw_event_reset(ir->rc);
> + ir->pulse_tunit = 0;
> + ir->pulse_count = 0;
> + }
> break;
> }
>
> @@ -1287,6 +1378,8 @@ static struct rc_dev *mceusb_init_rc_dev(struct mceusb_dev *ir)
> rc->priv = ir;
> rc->allowed_protocols = RC_PROTO_BIT_ALL_IR_DECODER;
> rc->timeout = MS_TO_NS(100);
> + rc->s_learning_mode = mceusb_set_rx_wideband;
> + rc->s_carrier_report = mceusb_set_rx_carrier_report;
> if (!ir->flags.no_tx) {
> rc->s_tx_mask = mceusb_set_tx_mask;
> rc->s_tx_carrier = mceusb_set_tx_carrier;
> --
> 2.11.0
>
