On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote: > According to the Devicetree Specification, "ok" is not a valid status. > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> There are a few other matches, too, it'd be nice to fix them as well: $ git grep 'status.*"ok"' -- Documentation/devicetree/bindings/ Documentation/devicetree/bindings/ata/apm-xgene.txt:- status : Shall be "ok" if enabled or "disabled" if disabled. Documentation/devicetree/bindings/display/hisilicon/dw-dsi.txt: status = "ok"; Documentation/devicetree/bindings/display/ti/ti,omap-dss.txt: status = "ok"; Documentation/devicetree/bindings/display/ti/ti,omap-dss.txt: status = "ok"; Documentation/devicetree/bindings/media/rcar_vin.txt: status = "ok"; Documentation/devicetree/bindings/media/rcar_vin.txt: status = "ok"; Documentation/devicetree/bindings/net/apm-xgene-enet.txt:- status: Should be "ok" or "disabled" for enabled/disabled. Default is "ok". Documentation/devicetree/bindings/net/apm-xgene-enet.txt: status = "ok"; Documentation/devicetree/bindings/net/apm-xgene-enet.txt: status = "ok"; Documentation/devicetree/bindings/pci/hisilicon-pcie.txt:- status: Either "ok" or "disabled". Documentation/devicetree/bindings/pci/xgene-pci.txt:- status: Either "ok" or "disabled". Documentation/devicetree/bindings/pci/xgene-pci.txt: status = "ok"; Documentation/devicetree/bindings/phy/apm-xgene-phy.txt:- status : Shall be "ok" if enabled or "disabled" if disabled. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx