Hi Sean,
Thanks again for your review and notes. I'm forwarding PATCH v3 after this note. Please also see my notes below. ..A Sun
On 3/15/2018 8:46 AM, Sean Young wrote:
> On Wed, Mar 14, 2018 at 03:32:02PM -0400, A Sun wrote:
>> patch v2 revisions:
>> . Carrier frequency measurement results were consistently low in patch v1.
>> Improve measurement accuracy by adjusting IR carrier cycle count
>> assuming 1 missed count per IR "on" pulse.
>> Adjustments may need to be hardware specific, so future refinements
>> may be necessary.
>
> I've retested my four mceusb devices. Three of them, including the original
> microsoft mce ir receiver, need this fix. However, one with pid 0471 and
> vid 2093 produces correct results before this change, and starts giving
> carrier with numbers which are too high after this.
>
Well, it appears the fix will need to be applied on a device specific basis.
In v3, I've added parameter "rx2" to mceusb_model to accomplish this.
I'm not sure how to proceed further with this. Many of the mceusb supported devices
would need to be checked to determine what "rx2" setting works best for the device.
I can only check two other mceusb devices I have access to. Maybe later, after we
complete this patch.
Can you identify your other mceusb devices by v/p-id? That would help too.
>> . Remove unneeded argument "enable" validation in
>> mceusb_set_rx_wideband() and mceusb_set_rx_carrier_report().
>> . In mceusb_set_rx_carrier_report(), when enabling RX carrier report feature,
>> also implicitly enable RX wide-band (short-range) receiver.
>> Maintains consistency with winbond-cir, redrat3, ene-cir, IR receivers.
>
> So if carrier reports are enabled, and then disabled again, in your code
> the wideband receiver remains enabled. Please can it be disabled again
> when carrier reports are turned off again (while learning mode is off).
>
I've added code in V3 to revert to normal receiver after disabling carrier reports,
but only if learning mode (wideband receiver) was not explicitly turned on.
file mceusb-rx2-setting.txt:
Mceusb confirmed device dependent setting for rx2 which provides
the best results for learning mode IR receiver carrier frequency
measurement.
IR receiver only devices (no IR emitters (no_tx = 1)) are
unlikely, and not required by specification, to support IR learning mode.
So those devices may not need to be checked.
* Original Microsoft MCE IR Transceiver (often HP-branded) *
USB_DEVICE(VENDOR_MICROSOFT, 0x006d)
rx2 = 2
* Philips IR transceiver (Dell branded) *
USB_DEVICE(VENDOR_PHILIPS, 0x2093)
rx2 = 1
* Pinnacle Remote Kit *
USB_DEVICE(VENDOR_PINNACLE, 0x0225)
rx2 = 2
