Hi Hans, Pavel, Mauro, others, On Mon, May 29, 2017 at 10:02:26AM +0200, Hans Verkuil wrote: > On 05/29/2017 09:32 AM, Pavel Machek wrote: > >On Mon 2017-05-29 08:13:22, Hans Verkuil wrote: > >>Hi Pavel, > >> > >>On 05/21/2017 12:33 PM, Pavel Machek wrote: > >>>Add simple SDL-based application for capturing photos. Manual > >>>focus/gain/exposure can be set, flash can be controlled and > >>>autofocus/autogain can be selected if camera supports that. > >>> > >>>It is already useful for testing autofocus/autogain improvements to > >>>the libraries on Nokia N900. > >>> > >>>Signed-off-by: Pavel Machek <pavel@xxxxxx> > >> > >>I think this is more suitable as a github project. To be honest, I feel that > >>v4l-utils already contains too many random utilities, so I prefer not to add > >>to that. > > > >>On the other hand, there is nothing against sharing this as on github as it > >>certainly can be useful. > > > >Can I get you to reconsider that? > > > >Originally, I planed to keep the utility separate, but then I got > >comments from Mauro ( https://lkml.org/lkml/2017/4/24/457 ) explaining > >that hard sdl dependency is not acceptable etc, and how I should do > >automake. > > > >So I had a lot of fun with automake integration, and generally doing > >things right. > > > >So getting "we all ready have too many utilities" _now_ is quite an > >unwelcome surprise. > > Too many *random* utilities. > > Utilities like v4l2-ctl are tied closely to the kernel and are updated whenever > new APIs appear. But yet another viewer? > > Mauro, I find that v4l-utils is a bit polluted with non-core utilities. > IMHO it should only contain the core libv4l2, core utilities and driver-specific > utilities. I wonder if we should make a media-utils-contrib for all the non-core > stuff. > > What is your opinion? One of the purposes the v4l-utils repository has is that the distributions get these programs included to their v4l-utils package as it's typically called. It's debatable whether or how much it should contain device specific or otherwise random projects, but having a common location for such programs has clear benefits, too. Based on how this one looks it is definitely not an end user application (I hope I'm not miscategorising it) and as Pavel mentioned, it has been useful in testing automatic focus / gain control on N900. Just my 5 euro cents... -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
