Hi, On Tue, Sep 15, 2009 at 09:21:46PM +0200, Andreas Mohr wrote: > Hi, > > On Tue, Sep 15, 2009 at 09:14:19PM +0200, Marcin Slusarz wrote: > > Or better: frame_timeout * HZ > > D'oh! ;-) > > But then what about the other 3 bazillion places in the kernel > doing multiples of seconds? > > linux-2.6.31]$ find . -name "*.c"|xargs grep msecs_to_jiffies|grep 1000|wc -l > 73 > > If this expression is really better (also/especially from a maintenance POV), > then it should get changed. I just saw that my unmodified patch has been committed. I think that that is ok or even preferrable, since "HZ" is a lot less greppable (you'd have to use "\<HZ\>") or uniform than msecs_to_jiffies. In terms of "number of traps avoided" the expressions should be equivalent. Thanks! Andreas Mohr -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
