On Friday 18 September 2009 06:40:34 Devin Heitmueller wrote: > Hello Hans, > > If you can find a few minutes, please take a look at the following > tree, where I added initial support for including the ALSA devices in > the MC enumeration. I also did a bit of cleanup on your example tool, > properly showing the fields associated with the given node type and > subtype (before it was always showing fields for the V4L subtype). > > http://kernellabs.com/hg/~dheitmueller/v4l-dvb-mc-alsa/ > > I've implemented it for em28xx as a prototype, and will probably see > how the code looks when calling it from au0828 and cx88 as well (to > judge the quality of the abstraction). > > Comments welcome, of course... Looks good. But rather than adding v4l2_device_register_alsa_node you should add a v4l2_device_register_entity. I intended to do that, but never got around to it. The entity struct is just part of the larger struct v4l2_alsa_device and you can go from one to the other using container_of. This way you don't need to make v4l2_device_register_fb_node and dvb_node, etc. A single generic register_entity is sufficient. Note that I am leaning more to replacing the v4l2 prefix by a media prefix. It's not really very v4l2-specific anymore. I think that most of what the media controller does can be generalized completely and used by pretty much anything that has complex mesh-like relationships. Too early to say for sure, though. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
