Hi, On Tue, Sep 15, 2009 at 09:14:19PM +0200, Marcin Slusarz wrote: > Andreas Mohr pisze: > > ./drivers/media/video/zc0301/zc0301_core.c > > do > > cam->module_param.frame_timeout * > > 1000 * msecs_to_jiffies(1) ); > > multiple times each. > > What they should do instead is > > frame_timeout * msecs_to_jiffies(1000), I'd think. > > Or better: frame_timeout * HZ D'oh! ;-) But then what about the other 3 bazillion places in the kernel doing multiples of seconds? linux-2.6.31]$ find . -name "*.c"|xargs grep msecs_to_jiffies|grep 1000|wc -l 73 If this expression is really better (also/especially from a maintenance POV), then it should get changed. > Marcin Andreas Mohr -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
