On Wed, 22 Jul 2009 00:19:00 -0700 (PDT) Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote: > On Mon, 20 Jul 2009, Andrew Morton wrote: > > On Mon, 20 Jul 2009 13:21:33 -0700 (PDT) > > Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote: > > > On Mon, 20 Jul 2009, Andrew Morton wrote: > > > I produced a patch that fixed this problem over a month ago, > > > http://www.linuxtv.org/hg/~tap/v4l-dvb/rev/748c762fcf3e > > > > Where is that patch now? It isn't present in linux-next. > > Mauro has how pulled it from me and so it will probably show up in his tree > soon. > > > Also, is there any way of avoiding this? > > > > +#define FE_SUPPORTED(fe) (defined(CONFIG_DVB_##fe) || \ > > + (defined(CONFIG_DVB_##fe##_MODULE) && defined(MODULE))) > > > > That's just way too tricky. It expects all versions of the > > preprocessor to be correctly implemented (unlikely) and there are other > > tools like unifdef which want to parse kernel #defines. > > What's so tricky about it? A quick grep shows hundreds of uses of > ## for concatenation. Not the concatenation, of course. The worrisomie thing is the macro which expands to preprocessor statements. It requires that the preprocessor run itself multiple times across the same line. Or something. I don't recall seeing that trick used elsewhere in the kernel and I have vague memories of it causing problems in the past. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
