Re: OMAP patches for linux-media

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Wed, 17 Jun 2009 08:30:13 +0200
Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:

> On Tuesday 16 June 2009 15:40:18 Mauro Carvalho Chehab wrote:
> > Hi Sakari and others,
> >
> > I'm seeing lots of patches and discussions for OMAP and DaVinci being
> > handled at the linux-media Mailing List, as part of the development
> > process of the open source drivers.
> >
> > However, it is hard to track all those discussions and be sure what
> > patches are ready for merging and what patches are just RFC.
> >
> > On the development model we use here, we have driver maintainers that are
> > responsible to discuss about improvements on their drivers. They are
> > generally the driver authors or the one that first started submitting the
> > patches for that driver(s).
> >
> > One of the roles of the driver maintainers is to collect the patches for
> > the drivers they maintain, merge on their trees, and periodically ask the
> > patch merge.
> >
> > One fundamental concept on Kernel development is the concept of "Commit
> > earlier and commit often", meaning that the better is to send small,
> > incremental, and periodic patches, than wait until having everything
> > done, then submit a big patch. Every time I receive a big patch I need to
> > postpone its analysis and open a big window on my schedule to analyze it.
> > Of course, this means to postpone it, and generally results on lots of
> > comments going back to developer, that, in turn, will need to do lots of
> > changes and return me back with another big patch for me to analyze
> > again, resulting on a long period of time for merging it.
> >
> > As you, Sakari, was the first one that started merging the OMAP drivers,
> > I was expecting that you would be the one that will handle the figure of
> > the driver maintainer for OMAP. I even created you an account at linuxtv
> > for you to create your trees there and ask me to merge from it.
> >
> > Unfortunately, you haven't sent me any pull requests yet along this year.
> > This is concerning me a lot, since, at the end, I'll need to review big
> > piles of patches and/or drivers when you decide to submit the final
> > version.
> >
> > So, I decided to send you this email, c/c a random list of people that I
> > believe are involved on the submit and/or review process of those
> > patches, in the hope to better understand and to discuss what's happening
> > and how can we speedup the merge process of those patches.
> 
> I have proposed this before, but I'll do it again: I'm more than happy to be 
> the official person who collects and organizes the omap and davinci patches 
> for you and who does the initial reviews. This is effectively already the 
> case since I've been reviewing both omap and davinci patches pretty much 
> from the beginning.

As I said before, in general the maintainer is the driver author or the first
submitter. Submitting patches for me is part of maintainer's hole. It is also a
maintainers responsibility to receive bug fixes and patches from other
developers and deal with them.

In the case where the chipset manufacturer is providing official support, it is
preferred if they are also handling this task. Of course they can delegate this
task to someone else.

While we are still bound to mercurial, the maintainer(s) should use it for
sending me pull requests, especially for a high traffic of patches like
what we're having. I hope we can migrate the development model to -git, but
this may still take some time.

>From my side, I'm ok if they prefer to delegate maintainer's task to you.
I'm also ok if they want to do by themselves. 

As there are multiple driver sets involved (OMAP, OMAP2, OMAP3, OMAP4, DaVinci),
eventually the task can be split on different maintainers, provided that I know
exactly who is maintaining what drivers.

Just let me know what fits better.

> Both the omap2/3 display driver and the davinci drivers are now very close 
> to be ready for inclusion in the kernel as my last reviews only found some 
> minor things.
>
> Part of the reason for the delays for both omap and davinci was that they 
> had to be modified for v4l2_subdev, which was an absolute necessity, and 
> because they simply needed quite a bit of work to make them suitable for 
> inclusion in the kernel.

Ok.



Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux