Re: [PULL] http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 15 Mar 2009, Devin Heitmueller wrote:
> au0828: remove memset calls in v4l2 routines.

"The userland callers are responsible for clearing the output buffers, so
remove the unneeded memset calls."

A driver should not assume that _userspace_ has cleared the buffers.  In
some cases userspace is supposed to clear certain fields, but you shouldn't
assume it.  AFAIK, for read-only ioctls there is no expectation at all that
userspace will clear the buffer.

Your patch is still right though, as now the videodev core will take care
of this so individual drivers don't have to.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux