On Mon, Mar 16, 2009 at 3:58 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > Looks great! > > I have one small final note (doesn't prevent this from going in): > > In au8522_decoder.c you can remove the 'normal_i2c[]' array and > the I2C_CLIENT_INSMOD macro. It's only relevant for kernels < 2.6.22. > > Note that you should replace the normal_i2c array with a comment telling the > reader which i2c address is used by this device. Or, alternatively, put that > info in au8522.h if it isn't there already (didn't check this). No problem. I had suspected that might need to be removed. I will add a patch to a series I have queuing up of stuff unrelated to the HVR-950q, and will submit a PULL request Tuesday night. Thanks for all your help, Devin -- Devin J. Heitmueller http://www.devinheitmueller.com AIM: devinheitmueller -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html