On Monday 16 March 2009 01:30:54 Devin Heitmueller wrote: > Hello Mauro, > > Please issue a pull request from > http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2 for the following: > > au0828: remove memset calls in v4l2 routines. > au0828: remove some unneeded braces > au0828: add entry for undefined input type > au0828/au8522: Codingstyle fixes > au0828: rename macro for currently non-function VBI support > au8522: move the analog decoder source file > au0828: finish videodev/subdev conversion > au8522: finish conversion to v4l2_device/subdev > > I believe this addresses all the outstanding comments from both you and Hans. Looks great! I have one small final note (doesn't prevent this from going in): In au8522_decoder.c you can remove the 'normal_i2c[]' array and the I2C_CLIENT_INSMOD macro. It's only relevant for kernels < 2.6.22. Note that you should replace the normal_i2c array with a comment telling the reader which i2c address is used by this device. Or, alternatively, put that info in au8522.h if it isn't there already (didn't check this). Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
