On Mon, Mar 16, 2009 at 2:05 PM, Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote: > On Sun, 15 Mar 2009, Devin Heitmueller wrote: >> au0828: remove memset calls in v4l2 routines. > > "The userland callers are responsible for clearing the output buffers, so > remove the unneeded memset calls." > > A driver should not assume that _userspace_ has cleared the buffers. In > some cases userspace is supposed to clear certain fields, but you shouldn't > assume it. AFAIK, for read-only ioctls there is no expectation at all that > userspace will clear the buffer. > > Your patch is still right though, as now the videodev core will take care > of this so individual drivers don't have to. Thanks for the feedback. Admittedly I just took Mauro's word that the buffers need to be cleared without fully investigating what is responsible. I guess I jumped to the conclusion that it was done in userland, when in fact it is done in the videodev core. My mistake. Regards, Devin -- Devin J. Heitmueller http://www.devinheitmueller.com AIM: devinheitmueller -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
