On Fri, 6 Mar 2009, Guennadi Liakhovetski wrote: > On Fri, 6 Mar 2009, robert.jarzmik@xxxxxxx wrote: > > > > This implies that even if DMA is 8 bytes aligned, width x height should > > be a multiple of 16, not 8 as I stated in the first git comment. So that > > would align : > > - width on 4 bytes (aligning meaning the lowest multiple of 4 below or equal to width) > > - and height on 4 bytes (aligning meaning the lowest multiple of 4 below or equal to height) > > > > Do we have an agreement on that specification, so that I can amend the code accordingly ? > > Yep, looks good to me. I like the algorithm I posted, after another small improvement, better. For instance, if width is aligned by 8 and height by 2, then you have already have 16 byte alignment and there is no need to align height by 4. E.g., 168x202 will be kept as 168x202 with my method but the rounding down method changes it to 168x200. Another example, take 159x243. My algorithm produces 160x243, which seems much better than 156x240, what one gets by rounding each dimention down to a multiple of four. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
