Dear Guennadi Thank you for checking patch. > camera - you will see, that almost all of them have a test "if (pixfmt)," > i.e., they have to differentiate between the two cases. And not only (snip) > cropping for both, but the recently added mt9t031 does support scaling, > so, it is indeed important. Not sure about mt9m111, and yours ov772x and > tw9910. hmm. I could understand. > Further, calling set_bus_param() from (or soc_camera_s_fmt_vid_cap()) from > S_CROP is not enough too. This lets the capture.c example run, but, I > think, we should be able to run with no configuration at all - even > without a S_CROP. So, some default configuration has to be set up on > open() or on STREAMON if none is set yet (current_fmt == NULL). I can agree with your opinion. On my opinion, not only calling set_bus_param but also try_fmt is important for tw9910. Because tw9910 needs "INTERLACE" mode, and sh_mobile_ceu sets "is_interlace flag" in try_fmt. This is the reason why I would like to call try_fmt (or s_fmt_vid_cap directly). And sh_mobile_ceu_dev :: camera_fmt is set in sh_mobile_ceu_set_fmt, and it is used in set_bus_param. but it need xlate->cam_fmt. you know xlate need pixfmt now.... This is the reason why I would like to use current_fmt to set_fmt. Therefore, I can agree with your "some default configuration has to be set up on open()" > So, you can either wit until I find time to address this, or try to do > something along these lines yourself. But I'm not sure if I manage to > propose anything meaningful before FOSDEM (next weekend), so, this might > take up to two weeks. But, I think, we have a bit of time before the > 2.6.30 merge window:-) OK. no problem for me. I can always help you if needed. Best regards -- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
