Dear Guennadi > > what is the best way to us ??? > > or do I miss understanding ??? > > Fix behaviour if no S_FMT is done. I attached stupid 4 patches. I would like to hear your opinion. please check it. I wonder is there any soc_camera that works without calling S_FMT though set_bus_param is not called ? If soc_camera works without calling S_FMT, s_crop should call try_fmt_vid_cap and set_bus_param like s_fmt_vid_cap I think. And I think "current_fmt" is better than 0 to set_fmt if user wants only geometry changes on s_crop. it mean keep format. These patches works well on my local environment. ov772x and tw9910 work even if without -f option on capture_example. If you can agree with this idea, I will send these as formal patch.
Attachment:
0001-tw9910-field-NONE-also-permits.patch
Description: Binary data
Attachment:
0002-sh_mobile_ceu-revert-b6c6173ee8af9e8723b76e12bd92e4.patch
Description: Binary data
Attachment:
0003-soc_camera-use-currect-format-on-s_crop.patch
Description: Binary data
Attachment:
0004-soc_camera-s_crop-behaves-like-s_fmt_vid_cap.patch
Description: Binary data
Best regards -- Kuninori Morimoto