On Tue, 27 Jan 2009, morimoto.kuninori@xxxxxxxxxxx wrote: > Dear Guennadi > > > > what is the best way to us ??? > > > or do I miss understanding ??? > > > > Fix behaviour if no S_FMT is done. > > I attached stupid 4 patches. > I would like to hear your opinion. > please check it. > > I wonder is there any soc_camera that works without > calling S_FMT though set_bus_param is not called ? Don't know, never tested that way. Might well be they don't, in which case they need to be fixed. > If soc_camera works without calling S_FMT, > s_crop should call try_fmt_vid_cap > and set_bus_param like s_fmt_vid_cap I think. > > And I think "current_fmt" is better than 0 to set_fmt > if user wants only geometry changes on s_crop. > it mean keep format. > > These patches works well on my local environment. > ov772x and tw9910 work even if without -f option on capture_example. > > If you can agree with this idea, > I will send these as formal patch. Thanks for the patches, please, give me a couple of days for review. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
