On 4/1/23 19:19, Günther Noack wrote: > Hello Alejandro! > > On Sat, Apr 01, 2023 at 12:29:35AM +0200, Alejandro Colomar wrote: >> Hi Günther, >> [...] >>> +.PP >>> +If our program needed to create hard links or rename files between different directories >> >> Please keep lines below 80 columns. Break lines at phrase >> boundaries as appropriate (e.g., in this line:) >> >> s/ or /\nor / > > Thanks, applied. Will be fixed in the next patch version. > > >>> +.RB ( LANDLOCK_ACCESS_FS_REFER ), >>> +we would require the following change to the backwards compatibility logic: >>> +Directory reparenting is not possible in a process restricted with Landlock ABI version 1. > > Fixed it on this line too. BTW, I forgot to tell you that you can check this yourself in future man-pages patches following the ./CONTRIBUTING file instructions for linting and checking patches. You might find this useful. See: <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING#n132> Lint & check If you plan to patch a manual page, consider running the linters and checks configured in the build system, to make sure your change doesn't add new warnings. However, you might still get warnings that are not your fault. To minimize that, do the following steps: (1) First use make(1)'s -t option, so that make(1) knows that it only needs to lint & check again pages that you will touch. $ make -t lint check >/dev/null (2) Run make(1) again, asking it to imagine that the page wou'll modify has been touched, to see which warnings you'll still see from that page that are not your fault. $ # replace 'man2/membarrier.2' by the page you'll modify $ make -W man2/membarrier.2 -k lint check (3) Apply your changes, and then run make(1) again. You can ignore warnings that you saw in step (2), but if you see any new ones, please fix them if you know how, or at least note them in your patch email. $ vi man2/membarrier.2 # do your work $ make -k lint check See <INSTALL> for a list of dependencies that this feature requires. If you can't meet them all, don't worry; it will still run the linters and checks that you have available. > > Thank you for the review and for applying the two earlier patches! > –Günther Cheers, Alex -- <http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
