Hi Adrian, On 12/4/19 8:00 AM, Adrian Reber wrote: > On Mon, Dec 02, 2019 at 11:14:55PM +0100, Christian Brauner wrote: >> On Mon, Dec 02, 2019 at 03:27:40PM +0100, Adrian Reber wrote: >>> Signed-off-by: Adrian Reber <areber@xxxxxxxxxx> >> >> I'm generally fine with all of this, so: >> >> Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx> >> >> but should this maybe also mention that a pid namespace either already >> needs to have a pid 1 or if it does not the chosen pid has to be set to >> 1. In short: >> "Callers may only choose a pid > 1 in a given pid namespace if an init >> process (i.e. a process with pid 1) already exists. Otherwise the pid >> entry for this pid namespace must be 1." >> or something like this. > > I like that. I will add this to v3. Do you have that v3? Thanks, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
