On Mon, Dec 02, 2019 at 03:27:40PM +0100, Adrian Reber wrote: > Signed-off-by: Adrian Reber <areber@xxxxxxxxxx> I'm generally fine with all of this, so: Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx> but should this maybe also mention that a pid namespace either already needs to have a pid 1 or if it does not the chosen pid has to be set to 1. In short: "Callers may only choose a pid > 1 in a given pid namespace if an init process (i.e. a process with pid 1) already exists. Otherwise the pid entry for this pid namespace must be 1." or something like this. Christian