Re: [PATCH 4/11] Atari: fix EtherNAT interrupt; conditonal platform device register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

On Wed, Jun 6, 2012 at 10:25 AM, Michael Schmitz
<schmitzmic@xxxxxxxxxxxxxx> wrote:
The 91c111 is well behaved and won't generate interrupts before the
card is properly started up so it does not hurt to enable the
interrupt as soon as we're sure the card is present.

OK if it behaves well.

When I wrote that comment, I thought I had seen some Atari-specific interrupt
enabling/disabling in the smc driver, but it turns out that was in the USB part.

That one is most certainly _not_ well behaved - enabling the interrupt
there does stop the kernel in its tracks.

I'm confident that interrupt disable/enable in the interrupt handler
is not required but this needs further testing still.

I didn't realize it before, but the EtherNAT CPLD acts as an interrupt
controller?
So you are probably better off creating a separate IRQ chip for it (IRQ 139
is USB, IRQ 140 is Ethernet). Then all this can be hidden in the EtherNAT
CPLD irq_chip methods.

BTW, are there any other IRQs generated by this CPLD?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux