Hi Michael,
On Wed, Jun 6, 2012 at 9:58 AM, Michael Schmitz
<schmitzmic@xxxxxxxxxxxxxx> wrote:
#define ATARI_ETHERNAT_PHYS_ADDR 0x80000000
-#define ATARI_ETHERNAT_IRQ 0xc3
+#define ATARI_ETHERNAT_IRQ 140
So the EtherNAT does have a working interrupt line?
It does - at least David's and others' do.
+ if (hwreg_present(enatc_virt)) {
+ *enatc_virt |= 0x2; /* enable SMC91C111 interrupt */
Do you really want to do that here?
Typically this is done by the driver itself, in its probe() routine.
That would mean adding a bit of platform specific code to the probe
routine - nothing major as we can infer the address of the config
register from the card's base address. If you think it's worth a try I
can change that. I'll have to redo this series anyway as you spotted
already.
The 91c111 is well behaved and won't generate interrupts before the
card is properly started up so it does not hurt to enable the
interrupt as soon as we're sure the card is present.
OK if it behaves well.
When I wrote that comment, I thought I had seen some Atari-specific interrupt
enabling/disabling in the smc driver, but it turns out that was in the USB part.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
