Re: [PATCH 4/11] Atari: fix EtherNAT interrupt; conditonal platform device register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

 #define ATARI_ETHERNAT_PHYS_ADDR       0x80000000
-#define ATARI_ETHERNAT_IRQ             0xc3
+#define ATARI_ETHERNAT_IRQ             140

So the EtherNAT does have a working interrupt line?

It does - at least David's and others' do.


+       if (hwreg_present(enatc_virt)) {
+               *enatc_virt |= 0x2;     /* enable SMC91C111 interrupt */

Do you really want to do that here?
Typically this is done by the driver itself, in its probe() routine.

That would mean adding a bit of platform specific code to the probe
routine - nothing major as we can infer the address of the config
register from the card's base address. If you think it's worth a try I
can change that. I'll have to redo this series anyway as you spotted
already.

The 91c111 is well behaved and won't generate interrupts before the
card is properly started up so it does not hurt to enable the
interrupt as soon as we're sure the card is present.

Cheers,

  Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux