Re: [PATCH 6/11] Atari: new EtherNEC driver (ne.c)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 6, 2012 at 10:05 AM, Michael Schmitz
<schmitzmic@xxxxxxxxxxxxxx> wrote:
+config ATARI_ETHERNEC
+       tristate "Atari EtherNEC Ethernet support"

I would make this bool, and move this section to arch/m68k/Kconfig.devices.
Then CONFIG_ATARI_ETHERNEC can control the creation of the platform
devices.

After that, you still need a way to make CONFIG_NE2000 selectable. E.g.
in drivers/net/ethernet/8390/Kconfig:

 config NE2000
        tristate "NE2000/NE1000 support"
-        depends on (ISA || (Q40 && m) || M32R || MACH_TX49XX)
+        depends on (ISA || (Q40 && m) || M32R || MACH_TX49XX || ATARI_ETHERNEC)

Can't we force NE2000 to be enabled whenever ATARI_ETHERNEC is enabled
by default? We would not want one without the other usually.

You can do a select NE2000 in the ETHERNEC part. But than ETHERNEC cannot
be boolean and must stay tristate. That may bypass other dependencies of NE2000,
though (e.g. NET).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux