Hi,
your commit 5b31f855f10d0053e738baa6d91fb6a3fad35119 (introduction of IDE lock
helpers) breaks Atari Falcon IDE on the first request going out to the drive, if
I remove the request_irq() call from ide-probe.c (as it should be).
I assume this is on real hardware, as I didn't notice on ARAnyM?
Followup: never mind, I found out that this patch fixes the problem for me:
(NB: still on ARAnyM, having two IDE drivers didn't matter, and I still have to
test the interaction of new IDE locking with SCSI)
Any other side effects of IDE_HFLAG_SERIALIZE ??
(Actually I realize I could have stuck the flag in
falconide_port_info.host_flags instead - works just as well. Pick whatever suits
the IDE guys best)
Michael
[m68k] Falcon IDE: always serialize, in order to force execution of
ide_get_lock() and friends.
Signed-off-By: Michael Schmitz <schmitz@xxxxxxxxxx>
---
diff --git a/drivers/ide/falconide.c b/drivers/ide/falconide.c
index a5ba820..7223dc3 100644
--- a/drivers/ide/falconide.c
+++ b/drivers/ide/falconide.c
@@ -132,6 +132,8 @@ static int __init falconide_init(void)
goto err;
}
+ host->host_flags |= IDE_HFLAG_SERIALIZE;
+
ide_get_lock(NULL, NULL);
rc = ide_host_register(host, &falconide_port_info, hws);
ide_release_lock();
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
