On Sat, 17 Jan 2009, Michael Schmitz wrote:
your commit 5b31f855f10d0053e738baa6d91fb6a3fad35119 (introduction of IDE lock
helpers) breaks Atari Falcon IDE on the first request going out to the drive, if
I remove the request_irq() call from ide-probe.c (as it should be).
I assume this is on real hardware, as I didn't notice on ARAnyM?
No, this was on ARAnyM (my git tree had the IDE irq request #ifdef'ed out for a
while now). I'm sure it would work the same on hardware.
Did you still get the IDE driver to work after taking out request_irq in
ide-probe?
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 0ccbb44..1571ab7 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -968,8 +968,10 @@ static int init_irq (ide_hwif_t *hwif)
if (io_ports->ctl_addr)
hwif->tp_ops->set_irq(hwif, 1);
+#if !defined(CONFIG_BLK_DEV_FALCON_IDE) && !defined(CONFIG_BLK_DEV_FALCON_IDE_M
if (request_irq(hwif->irq, &ide_intr, sa, hwif->name, hwif))
goto out_up;
+#endif
if (!hwif->rqsize) {
if ((hwif->host_flags & IDE_HFLAG_NO_LBA48) ||
If so, do you perchance have two IDE drivers defined in the ARAnyM config file?
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
