Hi,
On Tue, 17 Apr 2007, Standa Opichal wrote:
* the detect_native_features() dissapeared effectively
making a NATFEAT
capable kernel not operating on normal atari HW.
Why? What happens?
Well, in nf_init() it uses the nf_get_id() instruction which
is illegal on a normal m68k. Or am I missing something? Is that
trapped during the initialization?
It should be catched via the exception handling (via the __ex_table
entries after these functions), if that doesn't work for you I'd be very
interested in the details.
Anyway, so if I say have a 'short' variable with a value of 0xabcd
and I use it as an argument for an ellipsis function (the nf_call()
in our case) it would store it like '0xXXXXabcd' on the stack.
Is that upper XXXX guaranteed to be 0000? Or do I need to cast
the value to be 4 byte wide to make it 0000? I am sorry if these
are obvious things for gcc insiders, but I just seem to remember
seeing interesting problems related to this and I am almost positive
that this wasn't just the -mshort case.
You may have to look for signed issues.
There are also some calls in the NF interfaces which would be nice
to wrap with fewer arguments for the Linux kernel purposes. I'd be
for inline functions that would wrap them.
As I said I'm not really against wrapper, I'm just sceptical about
wrapping only so everything's wrapped. If there add some value (e.g. help
readability), there are fine.
Anyway, just post the source and we'll see, but please follow the Linux
coding style.
bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
