Hi, On Mon, 16 Apr 2007, Standa Opichal wrote:
* the detect_native_features() dissapeared effectively making a NATFEAT capable kernel not operating on normal atari HW.
Why? What happens?
* The nfeth.c file now doesn't use any wrappers around the nf_call() executions. I am not completely sure if this should be adopted as the default way to deal with natfeats as the nf_call() arguments are supposed to be all 4 byte long (that is the definition of the interface) whereas if left as is one needs to pay a lot of attention to all parameter sizes and necessary casting where appropriate.
The 4 byte alignment is the default anyway when pushing arguments on the stack, so you only need to take care of 64bit values, which need special handling anyway. I'm not completely opposed to wrappers, but I think there are overkill for simple callers and/or single users. The main reason I killed the wrappers is that they practically splitted the driver in two parts and added an extra layer, so I just replaced the wrappers with direct calls and just never bothered with them again. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
