Re: [PATCH] 2.6.18 m68k Atari: SCSI support - error handling update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christian, please apply this on top of my other 2.6.18 patch.

Fails to apply, even when I remove the previous scsi patch first. Did you
check out the debian patches from svn? 2.6.18 is in dists/sid/linux-2.6

Nope, I just took the patch relative to what I thought was the last clean
state of my tree. Turns out it wasn't all that clean :-(

Regarding the IDE failure reported by Petr: arch/m68k/atari/stdma.c has
the SA_SHIRQ flag in request_irq() commented out - that needs to be
reversed, or else the error return from request_irq needs to be ignored:

                if (request_irq(hwif->irq,&ide_intr,sa,hwif->name,hwgroup))
                        goto out_unlink;

==>

                if (request_irq(hwif->irq,&ide_intr,sa,hwif->name,hwgroup)) {
#if defined(__mc68000__) || defined(CONFIG_BLK_DEV_FALCON_IDE)
                        if (MACH_IS_ATARI && ATARIHW_PRESENT(IDE)) {
                                printk("ide-probe: not registered IDE interrupt for Falcon IDE!\n");
                        } else
#endif
                        goto out_unlink;
                }

Or just leave out the request_irq altogether for Falcon. I'm still unsure
whether having both stdma_irq and ide_intr active is OK ...

	Michael
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux