On Mon, Sep 02, 2024 at 04:17:15PM +0300, Andy Shevchenko wrote: > On Mon, Sep 02, 2024 at 02:41:01PM +0200, Marek Behún wrote: > > Recall that on Turris Omnia, the LED controller has a global brightness > > property, which allows the user to make the front LED panel dimmer. > > > > There is also a button on the front panel, which by default is > > configured so that pressing it changes the global brightness to a lower > > value (unless it is at 0%, in which case pressing the button changes the > > global brightness to 100%). > > > > Newer versions of the MCU firmware support informing the SOC that the > > brightness was changed by button press event via an interrupt. > > > > Now that we have the turris-omnia-mcu driver, which adds support for MCU > > interrupts, add the ability to inform the userspace (via a sysfs > > notification) that the global brightness was changed. > > ... > > > + ret = devm_device_add_group(dev, &omnia_led_controller_group); > > AFAIU the intention is to remove that API, hence this shall not be used. > Greg? OMG yes this should be with the group .is_visible method. Sorry.
