Hello Lee, this is v2 of Turris Omnia LED driver changes. v1 can be found at https://lore.kernel.org/linux-leds/20240902124104.14297-1-kabel@xxxxxxxxxx/ This series is for 6.12, but it depends on changes that have been merged to 6.11-rc3. Your for-leds-next branch is based on 6.11-rc1, so it won't apply there. Changes since v1: - patch 2 does away also with i2c_master_send() call, in favor of omnia_cmd_write() - patch 5 was rewritten to not use devm_device_add_group() anymore, since this function was deprecated. Instead, the sysfs_put() call for the "brightness" node is done the first time the IRQ handler is called, instead of driver probe. - the changes were done with 100 columns limit in mind - added 3 more "cosmetic" patches Marek Marek Behún (11): turris-omnia-mcu-interface.h: Move command execution function to global header leds: turris-omnia: Use command execution functions from the MCU driver turris-omnia-mcu-interface.h: Add LED commands related definitions to global header leds: turris-omnia: Use global header for MCU command definitions leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver leds: turris-omnia: Use dev_err_probe() where appropriate leds: turris-omnia: Use uppercase first letter in all comments leds: turris-omnia: Use 100 columns in the rest of the code ARM: dts: turris-omnia: Add global LED brightness change interrupt .../dts/marvell/armada-385-turris-omnia.dts | 1 + drivers/leds/leds-turris-omnia.c | 283 +++++++----------- .../platform/cznic/turris-omnia-mcu-base.c | 3 + drivers/platform/cznic/turris-omnia-mcu.h | 130 -------- include/linux/turris-omnia-mcu-interface.h | 148 ++++++++- 5 files changed, 257 insertions(+), 308 deletions(-) -- 2.44.2
