On Mon, Sep 02, 2024 at 02:59:45PM +0200, Marek Behún wrote: > On Mon, Sep 02, 2024 at 03:55:30PM +0300, Andy Shevchenko wrote: > > On Mon, Sep 02, 2024 at 02:40:57PM +0200, Marek Behún wrote: ... > > > #include <linux/bitfield.h> > > > +#include <linux/bitops.h> > > > > > #include <linux/bits.h> > > > > You may drop this one now, as guaranteed by bitops.h. > > How do I know that including bit.sh won't be ever deleted from > bitops.h? How do I? Somebody should start writing documentation (and tooling?) for all this header dependency hell we have in the Linux kernel project. > Is there some database which symbols are supposed to be provided by > which header, and not just randomly included from another header? Bottom line, more explicit inclusions are fine, but here is a proverb: "make a fool pray to God, he will break his forehead." Means that either radical approach (none or all) is not good. -- With Best Regards, Andy Shevchenko