On Sun, 30 Apr 2023, Hans de Goede wrote: > The desired default behavior of LED1 / the charge LED is breathing > while charging and on/solid when full. Since triggers cannot select > breathing, blink_set() gets called when charging. Use breathing > when the default "charging-blink-full-solid" trigger is used to > achieve the desired default behavior. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > Changes in v3: > - Also set on/off delay to 1000 so that we get a slow breathing effect, > this counter-acts the v2 cht_wc_leds_set_effect() change changing > the default delays from 1000 to 500 > --- > drivers/leds/leds-cht-wcove.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) Applied, thanks -- Lee Jones [李琼斯]