On Sun, Apr 30, 2023 at 09:59:47PM +0200, Hans de Goede wrote: > Hi All, > > Here is v3 of the patch series to add support for the LED controller > on Intel Cherry Trail Whiskey Cove PMICs. > > Changes in v3: > - Some comment tweaks and s/LED_OFF/0/ and s/LED_ON/1/ > - Refuse to load on the Yoga Tab 3 as it turns out the LED1 driver output > is connected to a haptic feedback motor there (and LED2 is unused) > > Changes in v2 (of my version of this): > - Address Pavel's small remarks on patch 1/5, > see patch 1/5's commit message for details > - Improve/extend pattern docs in Documentation/leds/leds-cht-wcove.rst > > This is based on the original patch for this from Yauhen Kharuzhy, > with additional work on top by me. > > This addresses the review remarks on the v2 posting from Yauhen: > - Since the PMIC is connected to the battery any changes we make to > the LED settings are permanent, even surviving reboot / poweroff. > Save LED1 register settings on probe() and if auto-/hw-control was > enabled on probe() restore the settings on remove() and shutdown(). > - Add support for the pattern trigger to select breathing mode > > This makes the charging LED on devices with these PMICs properly > reflect the charging status (this relies on sw control on most > devices) and this also allows control of the LED behind the pen > (digitizer on) symbol on the keyboard half of the Lenovo Yoga Book > 1 models. > > Regards, > > Hans Tested-by: Yauhen Kharuzhy <jekhor@xxxxxxxxx> Works at my Lenovo Yoga Book YB1-X91L. -- Yauhen Kharuzhy
