Hi All,
Here is v3 of the patch series to add support for the LED controller
on Intel Cherry Trail Whiskey Cove PMICs.
Changes in v3:
- Some comment tweaks and s/LED_OFF/0/ and s/LED_ON/1/
- Refuse to load on the Yoga Tab 3 as it turns out the LED1 driver output
is connected to a haptic feedback motor there (and LED2 is unused)
Changes in v2 (of my version of this):
- Address Pavel's small remarks on patch 1/5,
see patch 1/5's commit message for details
- Improve/extend pattern docs in Documentation/leds/leds-cht-wcove.rst
This is based on the original patch for this from Yauhen Kharuzhy,
with additional work on top by me.
This addresses the review remarks on the v2 posting from Yauhen:
- Since the PMIC is connected to the battery any changes we make to
the LED settings are permanent, even surviving reboot / poweroff.
Save LED1 register settings on probe() and if auto-/hw-control was
enabled on probe() restore the settings on remove() and shutdown().
- Add support for the pattern trigger to select breathing mode
This makes the charging LED on devices with these PMICs properly
reflect the charging status (this relies on sw control on most
devices) and this also allows control of the LED behind the pen
(digitizer on) symbol on the keyboard half of the Lenovo Yoga Book
1 models.
Regards,
Hans
Hans de Goede (4):
leds: cht-wcove: Add suspend/resume handling
leds: cht-wcove: Add support for breathing mode use hw_pattern sysfs
API
leds: cht-wcove: Set default trigger for charging LED
leds: cht-wcove: Use breathing when LED_INIT_DEFAULT_TRIGGER is set
Yauhen Kharuzhy (1):
leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver
Documentation/leds/index.rst | 1 +
Documentation/leds/leds-cht-wcove.rst | 38 ++
Documentation/leds/well-known-leds.txt | 2 +-
drivers/leds/Kconfig | 11 +
drivers/leds/Makefile | 1 +
drivers/leds/leds-cht-wcove.c | 477 +++++++++++++++++++++++++
6 files changed, 529 insertions(+), 1 deletion(-)
create mode 100644 Documentation/leds/leds-cht-wcove.rst
create mode 100644 drivers/leds/leds-cht-wcove.c
--
2.39.2
