Hi, > -----Original Message----- > From: Pavel Machek [mailto:pavel@xxxxxx] > Sent: Montag, 21. September 2020 10:31 > To: Marek Behun <marek.behun@xxxxxx> > Cc: Adrian Schmutzler <mail@xxxxxxxxxxxxxxxxxxx>; linux- > leds@xxxxxxxxxxxxxxx > Subject: Re: How to name multiple LEDs of the same type and color > > Hi! > > > > > My main interest here was/is that I started to evaluate how OpenWrt can > migrate from LED labels to the "new" color/function syntax and to me the rssi > leds are a dedicated type that should be supported. > > > So I fear I won't be helpful for the implementation of RSSI leds in the > kernel in general. > > Yep, I guess staying with old "label" is the right solution for you for now. > > > > For the three leds vs. set of leds discussion: Note that we are interested > in (and already do) exposing each LED to the user individually (in user-space > via sysfs), so the user can redefine the purpose of the LED freely based on > his/her desire. Therefore, a total abstraction of the set of LEDs as a single > entity would be detrimental for us here. > > > > > > > This is interesting. How does this work? Better signal => faster > > blinking? > > I suspect it is "no signal" -> "all LEDs off". "weak signal" -> "one LED on", > "medium signal" -> "two LEDs on", "string signal" -> "three LEDs on". Indeed, it's just on/off, no blinking. We essentially mirror the behavior of OEM firmwares in this case. The signal strength where one LED is active is defined in a config file by defining a range within 1 to 100. E.g. rssilow (1 < signal < 100), rssimediumlow (25 < signal < 100), rssimediumhigh (50 < signal < 100), rssihigh (75 < signal < 100) Therefore, the more LEDs you see, the better your RSSI is. Note that LEDs might have different (fixed) colors, i.e. low is red, mediumlow is amber, and the other two are green. Some vendors do it differently of course and have one LED "position" where the color changes, or LEDs go off again for high RSSI or whatever, but my example should be the most abundant case. FYI: Device example: https://dl.ubnt.com/datasheets/picostationm/picom2hp_DS.pdf OpenWrt rssileds code: https://github.com/openwrt/openwrt/blob/master/package/network/utils/rssileds/src/rssileds.c Hope this helps. Best Adrian > > Best regards, > Pavel >
Attachment:
openpgp-digital-signature.asc
Description: PGP signature
