On Mon, Dec 9, 2019 at 3:07 PM Dan Murphy <dmurphy@xxxxxx> wrote: > On 12/8/19 6:42 PM, Linus Walleij wrote: > > + led->reset = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_LOW); > > + if (IS_ERR(led->reset)) > > + return PTR_ERR(led->reset); > > What about EPROBE_DEFER? That's fine? I don't understand this comment, the driver will bail out and be retried if deferral happens. > Is the reset line optional or required? I see that this device does not > have DT docs and the call infers it is required. This driver does not use DT. It needs to be used with board files. > But can this be optional? Since there are no users in the kernel it doesn't matter, if it needs to be optional then whoever is going to use it can make it optional I suppose. I can't really half-guess use cases when noone is stepping up and providing one. Yours, Linus Walleij
