On Thu, Nov 14, 2019 at 07:30:14AM -0600, Dan Murphy wrote:
> Add the reg property to each channel node. This update is
> to accomodate the multicolor framework. In addition to the
> accomodation this allows the LEDs to be placed on any channel
> and allow designs to skip channels as opposed to requiring
> sequential order.
>
> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> CC: Shawn Guo <shawnguo@xxxxxxxxxx>
> CC: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> CC: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> CC: Fabio Estevam <festevam@xxxxxxxxx>
> CC: NXP Linux Team <linux-imx@xxxxxxx>
> ---
> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> index e8d800fec637..efc466ed1fea 100644
> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> @@ -257,29 +257,35 @@
> reg = <0x30>;
> clock-mode = /bits/ 8 <1>;
> status = "disabled";
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - chan0 {
> + chan@0 {
Again, why do not we rename it to led@0 as you update the bindings in
the last patch in the series?
Shawn
> chan-name = "R";
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> + reg = <0>;
> };
>
> - chan1 {
> + chan@1 {
> chan-name = "G";
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> + reg = <1>;
> };
>
> - chan2 {
> + chan@2 {
> chan-name = "B";
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> + reg = <2>;
> };
>
> - chan3 {
> + chan@3 {
> chan-name = "W";
> led-cur = /bits/ 8 <0x0>;
> max-cur = /bits/ 8 <0x0>;
> + reg = <3>;
> };
> };
>
> --
> 2.22.0.214.g8dca754b1e
>
